qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qtests: avoid printing comments before g_test_init()


From: Thomas Huth
Subject: Re: [PATCH] qtests: avoid printing comments before g_test_init()
Date: Mon, 20 Mar 2023 09:01:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 17/03/2023 18.05, Daniel P. Berrangé wrote:
The TAP protocol version line must be the first thing printed on
stdout. The migration test failed that requirement in certain
scenarios:

   # Skipping test: Userfault not available (builtdtime)
   TAP version 13
   # random seed: R02Sc120c807f11053eb90bfea845ba1e368
   1..32
   # Start of x86_64 tests
   # Start of migration tests
   ....

The TAP version is printed by g_test_init(), so we need to make
sure that any methods which print are run after that.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  tests/qtest/migration-test.c | 10 +++++++---
  1 file changed, 7 insertions(+), 3 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]