[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 21/24] target/s390x/tcg/mem_helper: Remove bad assert() statement
From: |
Thomas Huth |
Subject: |
[PULL 21/24] target/s390x/tcg/mem_helper: Remove bad assert() statement |
Date: |
Mon, 20 Mar 2023 14:03:27 +0100 |
The "assert(!nonfault)" statement can be triggered by running the
"mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
assert looks backward. We should only arrive there if nonfault was
true for the probe (otherwise the probe would have raised the
exception directly). I would think we could just remove the assert."
Fixes: 4049431478 ("target/s390x: Fix s390_probe_access for user-only")
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230317135737.597570-1-thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/s390x/tcg/mem_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
index 96b8ef61b5..b93dbd3dad 100644
--- a/target/s390x/tcg/mem_helper.c
+++ b/target/s390x/tcg/mem_helper.c
@@ -149,7 +149,6 @@ static inline int s390_probe_access(CPUArchState *env,
target_ulong addr,
nonfault, phost, ra);
if (unlikely(flags & TLB_INVALID_MASK)) {
- assert(!nonfault);
#ifdef CONFIG_USER_ONLY
/* Address is in TEC in system mode; see s390_cpu_record_sigsegv. */
env->__excp_addr = addr & TARGET_PAGE_MASK;
--
2.31.1
- [PULL 06/24] tests/tcg/s390x: Add rxsbg.c, (continued)
- [PULL 06/24] tests/tcg/s390x: Add rxsbg.c, Thomas Huth, 2023/03/20
- [PULL 09/24] target/s390x: Handle branching to odd addresses, Thomas Huth, 2023/03/20
- [PULL 08/24] tests/tcg/s390x: Add ex-relative-long.c, Thomas Huth, 2023/03/20
- [PULL 10/24] target/s390x: Handle EXECUTE of odd addresses, Thomas Huth, 2023/03/20
- [PULL 13/24] target/s390x: Handle LLGFRL from non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 11/24] target/s390x: Handle LGRL from non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 12/24] target/s390x: Handle LRL and LGFRL from non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 15/24] target/s390x: Handle CGRL and CLGRL with non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 02/24] target/s390x: Fix LPSW, Thomas Huth, 2023/03/20
- [PULL 14/24] target/s390x: Handle CRL and CGFRL with non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 21/24] target/s390x/tcg/mem_helper: Remove bad assert() statement,
Thomas Huth <=
- [PULL 03/24] target/s390x: Implement Early Exception Recognition, Thomas Huth, 2023/03/20
- [PULL 20/24] tests/tcg/s390x: Test unaligned accesses, Thomas Huth, 2023/03/20
- [PULL 19/24] target/s390x: Update do_unaligned_access() comment, Thomas Huth, 2023/03/20
- [PULL 24/24] replace TABs with spaces, Thomas Huth, 2023/03/20
- [PULL 17/24] target/s390x: Handle STRL to non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 16/24] target/s390x: Handle CLRL and CLGFRL with non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 23/24] qemu/osdep: Switch position of "extern" and "G_NORETURN", Thomas Huth, 2023/03/20
- [PULL 18/24] target/s390x: Handle STGRL to non-aligned addresses, Thomas Huth, 2023/03/20
- [PULL 22/24] tests/unit/test-blockjob: Disable complete_in_standby test, Thomas Huth, 2023/03/20
- Re: [PULL 00/24] s390x and misc patches for 8.0-rc1, Thomas Huth, 2023/03/20