Re: [RFC PATCH for 8.1 1/6] vdpa: Remove status in reset tracing

[Eugenio Perez Martin]

On Wed, Mar 22, 2023 at 3:22 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Fri, Mar 17, 2023 at 03:55:37PM +0100, Eugenio Pérez wrote:
> >It is always 0 and it is not useful to route call through file
> >descriptor.
>
> I didn't get the second part of the sentence (after "and"),

Right, it is totally not explained.

Next patches need to call VHOST_VDPA_SET_STATUS(0) using vdpa file
descriptor, not struct vhost_dev. This patch prepares the way to
transform this function that way.

I'll add in the log for the next version, thanks!

> anyway the
> patch LGTM:
>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
> >
> >Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> >---
> > hw/virtio/vhost-vdpa.c | 2 +-
> > hw/virtio/trace-events | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> >index bc6bad23d5..bbabea18f3 100644
> >--- a/hw/virtio/vhost-vdpa.c
> >+++ b/hw/virtio/vhost-vdpa.c
> >@@ -716,7 +716,7 @@ static int vhost_vdpa_reset_device(struct vhost_dev *dev)
> >     uint8_t status = 0;
> >
> >     ret = vhost_vdpa_call(dev, VHOST_VDPA_SET_STATUS, &status);
> >-    trace_vhost_vdpa_reset_device(dev, status);
> >+    trace_vhost_vdpa_reset_device(dev);
> >     v->suspended = false;
> >     return ret;
> > }
> >diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events
> >index 8f8d05cf9b..6265231683 100644
> >--- a/hw/virtio/trace-events
> >+++ b/hw/virtio/trace-events
> >@@ -44,7 +44,7 @@ vhost_vdpa_set_mem_table(void *dev, uint32_t nregions, 
> >uint32_t padding) "dev: %
> > vhost_vdpa_dump_regions(void *dev, int i, uint64_t guest_phys_addr, 
> > uint64_t memory_size, uint64_t userspace_addr, uint64_t flags_padding) 
> > "dev: %p %d: guest_phys_addr: 0x%"PRIx64" memory_size: 0x%"PRIx64" 
> > userspace_addr: 0x%"PRIx64" flags_padding: 0x%"PRIx64
> > vhost_vdpa_set_features(void *dev, uint64_t features) "dev: %p features: 
> > 0x%"PRIx64
> > vhost_vdpa_get_device_id(void *dev, uint32_t device_id) "dev: %p device_id 
> > %"PRIu32
> >-vhost_vdpa_reset_device(void *dev, uint8_t status) "dev: %p status: 
> >0x%"PRIx8
> >+vhost_vdpa_reset_device(void *dev) "dev: %p"
> > vhost_vdpa_get_vq_index(void *dev, int idx, int vq_idx) "dev: %p idx: %d vq 
> > idx: %d"
> > vhost_vdpa_set_vring_ready(void *dev) "dev: %p"
> > vhost_vdpa_dump_config(void *dev, const char *line) "dev: %p %s"
> >--
> >2.31.1
> >
>