[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH for 8.1 4/6] vdpa: return errno in vhost_vdpa_get_vring_g
|
From: |
Eugenio Perez Martin |
|
Subject: |
Re: [RFC PATCH for 8.1 4/6] vdpa: return errno in vhost_vdpa_get_vring_group error |
|
Date: |
Wed, 22 Mar 2023 18:38:21 +0100 |
On Wed, Mar 22, 2023 at 3:26 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Fri, Mar 17, 2023 at 03:55:40PM +0100, Eugenio Pérez wrote:
> >We need to tell in the caller, as some errors are expected in a normal
> >workflow. In particular, parent drivers in recent kernels with
> >VHOST_BACKEND_F_IOTLB_ASID may not support vring groups. In that case,
> >-ENOTSUP is returned.
>
> So, should we also avoid the error_report if we expect a failure?
>
It's actually replaced by error_setg in next patches, but I think it
is worth commenting on the patch message for sure.
Thanks!
[RFC PATCH for 8.1 3/6] vdpa: add vhost_vdpa_set_dev_features_fd, Eugenio Pérez, 2023/03/17
[RFC PATCH for 8.1 6/6] vdpa: Cache cvq group in VhostVDPAState, Eugenio Pérez, 2023/03/17
[RFC PATCH for 8.1 5/6] vdpa: move CVQ isolation check to net_init_vhost_vdpa, Eugenio Pérez, 2023/03/17