Re: [PATCH v3 1/3] qtest: Add functions for accessing devices on Aspeed I2C controller

[Cédric Le Goater]

> +static void aspeed_i2c_write_n(uint32_t baseaddr, uint8_t slave_addr,
> > +                               uint8_t reg, uint32_t v, size_t nbytes)
> > +{
> > +    size_t i;
> > +
> > +    aspeed_i2c_startup(baseaddr, slave_addr, reg);
> > +
> > +    for (i = 0; i < nbytes; i++) {
> > +        writel(baseaddr + A_I2CD_BYTE_BUF, v & 0xff);
> > +        v >>= 8;
> > +        writel(baseaddr + A_I2CD_CMD, A_I2CD_M_TX_CMD);
> > +    }
> > +
> > +    writel(baseaddr + A_I2CD_CMD, A_I2CD_M_STOP_CMD);
> > +}
> > +
> > +void aspeed_i2c_writel(uint32_t baseaddr, uint8_t slave_addr,
> > +                       uint8_t reg, uint32_t v)
> > +{
> > +    aspeed_i2c_write_n(baseaddr, slave_addr, reg, v, sizeof(v));
> > +}
> > +
> > +void aspeed_i2c_writew(uint32_t baseaddr, uint8_t slave_addr,
> > +                       uint8_t reg, uint16_t v)
> > +{
> > +    aspeed_i2c_write_n(baseaddr, slave_addr, reg, v, sizeof(v));
> > +}
> > +
> > +void aspeed_i2c_writeb(uint32_t baseaddr, uint8_t slave_addr,
> > +                       uint8_t reg, uint8_t v)
> > +{
> > +    aspeed_i2c_write_n(baseaddr, slave_addr, reg, v, sizeof(v));
> > +}
>
> For helper functions like this, I'd recommend to not use libqtest-single.h and 
> rather pass in a QTestState* as parameter to use qtest_writel() and 
> qtest_readl() instead. That will make the code future-proof in case someone 
> wants to use these function for migration-related tests later.

Indeed. Talking of which, I should convert tests/qtest/aspeed_smc-test.c

Thanks,

C.