Re: [RFC PATCH v2 16/44] target/loongarch: Implement vmadd/vmsub/vmaddw{ev/od}

[Richard Henderson]

On 3/27/23 20:06, Song Gao wrote:
> +static void gen_vmadd(unsigned vece, TCGv_vec t, TCGv_vec a, TCGv_vec b)
> +{
> +    TCGv_vec t1;
> +
> +    t1 = tcg_temp_new_vec_matching(t);
> +    tcg_gen_mul_vec(vece, t1, a, b);
> +    tcg_gen_add_vec(vece, t, t, t1);
> +}
> +
> +static void do_vmadd(unsigned vece, uint32_t vd_ofs, uint32_t vj_ofs,
> +                     uint32_t vk_ofs, uint32_t oprsz, uint32_t maxsz)
> +{
> +    static const TCGOpcode vecop_list[] = {
> +        INDEX_op_mul_vec, INDEX_op_add_vec, 0
> +        };
> +    static const GVecGen3 op[4] = {
> +        {
> +            .fniv = gen_vmadd,
> +            .fno = gen_helper_vmadd_b,
> +            .load_dest = true,
> +            .opt_opc = vecop_list,
> +            .vece = MO_8
> +        },
> +        {
> +            .fniv = gen_vmadd,
> +            .fno = gen_helper_vmadd_h,
> +            .load_dest = true,
> +            .opt_opc = vecop_list,
> +            .vece = MO_16
> +        },
> +        {
> +            .fniv = gen_vmadd,
> +            .fno = gen_helper_vmadd_w,
> +            .load_dest = true,
> +            .opt_opc = vecop_list,
> +            .vece = MO_32
> +        },
> +        {
> +            .fniv = gen_vmadd,
> +            .fno = gen_helper_vmadd_d,
> +            .load_dest = true,
> +            .opt_opc = vecop_list,
> +            .vece = MO_64
> +        },
> +    };
> +
> +    tcg_gen_gvec_3(vd_ofs, vj_ofs, vk_ofs, oprsz, maxsz, &op[vece]);
> +}

Integer expansion?  Anyway,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~