Re: [RFC PATCH v2 01/44] target/loongarch: Add LSX data type VReg

[gaosong]

在 2023/3/29 上午3:56, Richard Henderson 写道:

> > @@ -33,7 +33,39 @@
> >         const VMStateDescription vmstate_loongarch_cpu = {
> >         
> >                     VMSTATE_UINTTL_ARRAY(env.gpr, LoongArchCPU, 32),
> >         
> >                   VMSTATE_UINTTL(env.pc, LoongArchCPU),
> >         
> >         -        VMSTATE_UINT64_ARRAY(env.fpr, LoongArchCPU, 32),
> >         
> >         +        VMSTATE_INT64(env.fpr[0].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[1].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[2].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[3].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[4].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[5].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[6].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[7].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[8].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[9].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[10].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[11].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[12].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[13].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[14].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[15].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[16].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[17].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[18].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[19].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[20].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[21].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[22].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[23].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[24].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[25].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[26].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[27].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[28].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[29].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[30].vreg.D(0), LoongArchCPU),
> >         
> >         +        VMSTATE_INT64(env.fpr[31].vreg.D(0), LoongArchCPU),
> >         
> >       
>       
>       Do you care about migration compatibility between qemu versions?
>       
>       If not, it might be easier to handle the vector registers
>       differently.
>       
>     
    Since our features are not yet complete,   such as  128 bit vector
    instrcutions,   256 bit vector instructions
    and kvm ,  we don't care about this now. 
    
    Thanks.
    Song Gao