[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 13/19] openpic: remove irq_out
From: |
Alexander Graf |
Subject: |
[Qemu-ppc] [PATCH 13/19] openpic: remove irq_out |
Date: |
Sat, 8 Dec 2012 14:44:36 +0100 |
The current openpic emulation contains half-ready code for bypass mode.
Remove it, so that when someone wants to finish it they can start from a
clean state.
Signed-off-by: Alexander Graf <address@hidden>
---
hw/openpic.c | 8 ++------
hw/openpic.h | 4 ++--
hw/ppc/e500.c | 2 +-
hw/ppc_newworld.c | 2 +-
4 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index f3e53b6..321c6d4 100644
--- a/hw/openpic.c
+++ b/hw/openpic.c
@@ -236,8 +236,6 @@ typedef struct OpenPICState {
uint32_t ticc; /* Global timer current count register */
uint32_t tibc; /* Global timer base count register */
} timers[MAX_TMR];
- /* IRQ out is used when in bypass mode (not implemented) */
- qemu_irq irq_out;
int max_irq;
int irq_ipi0;
int irq_tim0;
@@ -1050,7 +1048,7 @@ static void openpic_irq_raise(OpenPICState *opp, int
n_CPU, IRQ_src_t *src)
}
qemu_irq *openpic_init (MemoryRegion **pmem, int nb_cpus,
- qemu_irq **irqs, qemu_irq irq_out)
+ qemu_irq **irqs)
{
OpenPICState *opp;
int i;
@@ -1099,7 +1097,6 @@ qemu_irq *openpic_init (MemoryRegion **pmem, int nb_cpus,
for (i = 0; i < nb_cpus; i++)
opp->dst[i].irqs = irqs[i];
- opp->irq_out = irq_out;
register_savevm(&opp->pci_dev.qdev, "openpic", 0, 2,
openpic_save, openpic_load, opp);
@@ -1112,7 +1109,7 @@ qemu_irq *openpic_init (MemoryRegion **pmem, int nb_cpus,
}
qemu_irq *mpic_init (MemoryRegion *address_space, hwaddr base,
- int nb_cpus, qemu_irq **irqs, qemu_irq irq_out)
+ int nb_cpus, qemu_irq **irqs)
{
OpenPICState *mpp;
int i;
@@ -1158,7 +1155,6 @@ qemu_irq *mpic_init (MemoryRegion *address_space, hwaddr
base,
for (i = 0; i < nb_cpus; i++)
mpp->dst[i].irqs = irqs[i];
- mpp->irq_out = irq_out;
/* Enable critical interrupt support */
mpp->flags |= OPENPIC_FLAG_IDE_CRIT;
diff --git a/hw/openpic.h b/hw/openpic.h
index 1232d10..8a68f20 100644
--- a/hw/openpic.h
+++ b/hw/openpic.h
@@ -15,7 +15,7 @@ enum {
#define OPENPIC_FLAG_IDE_CRIT (1 << 0)
qemu_irq *openpic_init (MemoryRegion **pmem, int nb_cpus,
- qemu_irq **irqs, qemu_irq irq_out);
+ qemu_irq **irqs);
qemu_irq *mpic_init (MemoryRegion *address_space, hwaddr base,
- int nb_cpus, qemu_irq **irqs, qemu_irq irq_out);
+ int nb_cpus, qemu_irq **irqs);
#endif /* __OPENPIC_H__ */
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index f3e97d8..3f6d58c 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -493,7 +493,7 @@ void ppce500_init(PPCE500Params *params)
/* MPIC */
mpic = mpic_init(ccsr_addr_space, MPC8544_MPIC_REGS_OFFSET,
- smp_cpus, irqs, NULL);
+ smp_cpus, irqs);
if (!mpic) {
cpu_abort(env, "MPIC failed to initialize\n");
diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c
index 664747e..b9c2cd8 100644
--- a/hw/ppc_newworld.c
+++ b/hw/ppc_newworld.c
@@ -320,7 +320,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *args)
exit(1);
}
}
- pic = openpic_init(&pic_mem, smp_cpus, openpic_irqs, NULL);
+ pic = openpic_init(&pic_mem, smp_cpus, openpic_irqs);
if (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) {
/* 970 gets a U3 bus */
pci_bus = pci_pmac_u3_init(pic, get_system_memory(), get_system_io());
--
1.6.0.2
- Re: [Qemu-ppc] [PATCH 10/19] openpic: remove unused type variable, (continued)
- [Qemu-ppc] [PATCH 03/19] openpic: update to proper memory api, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 04/19] openpic: combine mpic and openpic src handlers, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 12/19] openpic: rename openpic_t to OpenPICState, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 18/19] PPC: e500: Declare pci bridge as bridge, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 09/19] openpic: unify memory api subregions, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 19/19] MSI-X: Fix endianness, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 08/19] openpic: combine openpic and mpic reset functions, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 13/19] openpic: remove irq_out,
Alexander Graf <=
- [Qemu-ppc] [PATCH 05/19] openpic: Convert subregions to memory api, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 17/19] PPC: e500: Add MSI support, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 01/19] openpic: Remove unused code, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 07/19] openpic: merge mpic and openpic timer handling, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 06/19] openpic: combine mpic and openpic irq raise functions, Alexander Graf, 2012/12/08
- [Qemu-ppc] [PATCH 16/19] openpic: add Shared MSI support, Alexander Graf, 2012/12/08