[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/15] ppc/ppc405: Fix bi_pci_enetaddr2 field in U-Boot board
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 13/15] ppc/ppc405: Fix bi_pci_enetaddr2 field in U-Boot board information |
Date: |
Mon, 6 Dec 2021 14:25:19 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/6/21 11:37, Cédric Le Goater wrote:
> The board information for the 405EP first appeared in commit 04f20795ac81
> ("Move PowerPC 405 specific definitions into a separate file ...")
> An Ethernet address is a 6 byte number. Fix that.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/ppc/ppc405.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h
> index 6fb8b41bbc77..83f156f585c8 100644
> --- a/hw/ppc/ppc405.h
> +++ b/hw/ppc/ppc405.h
> @@ -57,7 +57,7 @@ struct ppc4xx_bd_info_t {
> uint32_t bi_plb_busfreq;
> uint32_t bi_pci_busfreq;
> uint8_t bi_pci_enetaddr[6];
> - uint32_t bi_pci_enetaddr2[6];
> + uint8_t bi_pci_enetaddr2[6]; /* PPC405EP specific */
Also eventually 6 -> ETH_ALEN from "net/net.h".
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> uint32_t bi_opbfreq;
> uint32_t bi_iic_fast[2];
> };
>
- [PATCH 00/15] ppc/ppc405: decade cleanup, Cédric Le Goater, 2021/12/06
- [PATCH 13/15] ppc/ppc405: Fix bi_pci_enetaddr2 field in U-Boot board information, Cédric Le Goater, 2021/12/06
- Re: [PATCH 13/15] ppc/ppc405: Fix bi_pci_enetaddr2 field in U-Boot board information,
Philippe Mathieu-Daudé <=
- [PATCH 01/15] ppc/ppc405: Change kernel load address, Cédric Le Goater, 2021/12/06
- [PATCH 02/15] ppc: Mark the 'taihu' machine as deprecated, Cédric Le Goater, 2021/12/06
- [PATCH 04/15] ppc/ppc405: Convert printfs to trace-events, Cédric Le Goater, 2021/12/06
- [PATCH 06/15] ppc/ppc405: Change ppc405ep_init() return value, Cédric Le Goater, 2021/12/06
- [PATCH 07/15] ppc/ppc405: Add some address space definitions, Cédric Le Goater, 2021/12/06
- [PATCH 03/15] ppc: Add trace-events for DCR accesses, Cédric Le Goater, 2021/12/06