Re: [PATCH 07/15] ppc/ppc405: Add some address space definitions

[Cédric Le Goater]

On 12/6/21 16:05, BALATON Zoltan wrote:
> On Mon, 6 Dec 2021, Cédric Le Goater wrote:
> > Signed-off-by: Cédric Le Goater <clg@kaod.org>
> > ---
> > hw/ppc/ppc405.h        |  7 +++++++
> > hw/ppc/ppc405_boards.c | 16 +++++++---------
> > 2 files changed, 14 insertions(+), 9 deletions(-)
> >
> > diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h
> > index ad5f4026b5db..ea48c3626908 100644
> > --- a/hw/ppc/ppc405.h
> > +++ b/hw/ppc/ppc405.h
> > @@ -27,6 +27,13 @@
> >
> > #include "hw/ppc/ppc4xx.h"
> >
> > +#define PPC405EP_SDRAM_BASE 0x00000000
> > +#define PPC405EP_NVRAM_BASE 0xF0000000
> > +#define PPC405EP_FPGA_BASE  0xF0300000
> > +#define PPC405EP_SRAM_BASE  0xFFF00000
> > +#define PPC405EP_SRAM_SIZE  (512 * KiB)
> > +#define PPC405EP_FLASH_BASE 0xFFF80000
>
> Are these specific to the 405EP SoC itself or the board? 

yes.

> Maybe it's better to put these in the board .c file and get rid of the ppc405.h later if there are no 405 specific parts needed. 

Not yet. But I am moving to the ppc405_uc.c file parts related to
the board information and ppc405_uc.c is really 405 specific. See
other patches.

> It's currently included also by 440 machines because it has some functions re-used by them 

Indeed in hw/ppc/sam460ex.c:

        ppc405_ebc_init(env)

> but those may be gone when QOM-ifying these eventually 

QOM-ifying the 405 devices should be straight forward for most.
We can do a few to cleanup the dependencies like above. All models
will need a CPU link for the dcr handlers.

> or could be moved to a ppc4xx.h instead. 

yes. that would be fine but not necessary if we QOM-ify some parts.

> I've tried to make a distinction between 405, 440 and 4xx parts (the latter 
> common to both) when adding sam460ex but did not finish this clean up 
> completely.

I have a little patch removing all the printfs I will send soon.
Then we can move some code around.

I put some efforts on the 405 because it has been dead for so long
and at some point we need to identify dead code. It's alive now,
4.16 boots, we could even add PCI and network but first, user space
needs some care.

Thanks,

C.