qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] target/ppc: Fix xs{max,min}[cj]dp to use VSX registers


From: Richard Henderson
Subject: Re: [PATCH 1/4] target/ppc: Fix xs{max,min}[cj]dp to use VSX registers
Date: Sat, 11 Dec 2021 09:02:12 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/10/21 6:13 AM, Victor Colombo wrote:
PPC instruction xsmaxcdp, xsmincdp, xsmaxjdp, and xsminjdp are using
vector registers when they should be using VSX ones. This happens
because the instructions are using GEN_VSX_HELPER_R3, which adds 32
to the register numbers, effectively making them vector registers.

This patch fixes it by changing these instructions to use
GEN_VSX_HELPER_X3.

Signed-off-by: Victor Colombo<victor.colombo@eldorado.org.br>
---
  target/ppc/fpu_helper.c             | 4 ++--
  target/ppc/helper.h                 | 8 ++++----
  target/ppc/translate/vsx-impl.c.inc | 8 ++++----
  3 files changed, 10 insertions(+), 10 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]