Re: [PATCH v3] target/ppc: Machine check on invalid real address access on POWER9/10

[BALATON Zoltan]

On Thu, 6 Jul 2023, BALATON Zoltan wrote:
> On Thu, 6 Jul 2023, Cédric Le Goater wrote:
> > On 7/6/23 09:32, Nicholas Piggin wrote:
> > > On Mon Jul 3, 2023 at 10:03 PM AEST, Nicholas Piggin wrote:
> > > > ppc currently silently accepts invalid real address access. Catch
> > > > these and turn them into machine checks on POWER9/10 machines.
> > >
> > > Would there be any objections to merging this and the checkstop patch?
> > > We could disable this one before release if it turns out to cause
> > > breakage.
> > >
> > > I don't think it needs to rebase, and passes clang build and make check
> > > here. Just messed up the separator on the changelog of the checkstop
> > > patch.
> >
> > I have been using the v2 series for a while :
> >
> >  https://patchwork.ozlabs.org/project/qemu-ppc/list/?series=361456
> >
> > without patch 4 and it looked good. Let's take v3 since this patch is
> > unchanged.
>
> I think there was a newer version that dropped the test for the MSR bit from 
> the checkstop function and left that at the call site to avoid adding a one 
> line wrapper later. This version does not seem to be that so probably the 
> next iteration is better but I was lost following these series..

Or that was this one but then what's v3? I'm completely confused now about 
these so I'll just stop trying to follow. I've already said I'll only 
rebase my series changing excp_helper in next devel cycle so just go on 
with this without me, hopefully that's less confusing because at least 
one source of possible conflict is out of picture for now.

Regards,
BALATON Zoltan