Re: [PATCH v3] target/ppc: Machine check on invalid real address access on POWER9/10

[Cédric Le Goater]

On 7/6/23 13:43, BALATON Zoltan wrote:
> On Thu, 6 Jul 2023, Cédric Le Goater wrote:
> > On 7/6/23 09:32, Nicholas Piggin wrote:
> > > On Mon Jul 3, 2023 at 10:03 PM AEST, Nicholas Piggin wrote:
> > > > ppc currently silently accepts invalid real address access. Catch
> > > > these and turn them into machine checks on POWER9/10 machines.
> > >
> > > Would there be any objections to merging this and the checkstop patch?
> > > We could disable this one before release if it turns out to cause
> > > breakage.
> > >
> > > I don't think it needs to rebase, and passes clang build and make check
> > > here. Just messed up the separator on the changelog of the checkstop
> > > patch.
> >
> > I have been using the v2 series for a while :
> >
> >  https://patchwork.ozlabs.org/project/qemu-ppc/list/?series=361456
> >
> > without patch 4 and it looked good. Let's take v3 since this patch is
> > unchanged.
>
> I think there was a newer version that dropped the test for the MSR bit from 
> the checkstop function and left that at the call site to avoid adding a one 
> line wrapper later. This version does not seem to be that so probably the next 
> iteration is better but I was lost following these series..

Yes. It was a bit confusing to track for me also. Things should
cool down with soft freeze. After that, I am in favor of dealing
with large series !

Thanks

C.