Re: [PATCH 12/12] target/mips: Use generic hrev32_tl() in WSBH opcode

[Philippe Mathieu-Daudé]

On 22/8/23 17:42, Richard Henderson wrote:
> On 8/22/23 05:57, Philippe Mathieu-Daudé wrote:
> > -        {
> > -            TCGv t1 = tcg_temp_new();
> > -            TCGv t2 = tcg_constant_tl(0x00FF00FF);
> > -
> > -            tcg_gen_shri_tl(t1, t0, 8);
> > -            tcg_gen_and_tl(t1, t1, t2);
> > -            tcg_gen_and_tl(t0, t0, t2);
> > -            tcg_gen_shli_tl(t0, t0, 8);
> > -            tcg_gen_or_tl(t0, t0, t1);
> > -            tcg_gen_ext32s_tl(cpu_gpr[rd], t0);
> > -        }
> > +        tcg_gen_hrev32_tl(t0, t0);
> > +        tcg_gen_ext32s_tl(cpu_gpr[rd], t0);
>
> Ah, you did want tcg_gen_bswap16x2_tl(dst, src, TCG_BSWAP_OS).

Got it (per your reply to the cover).

> r~