Re: [PATCH v2 for-8.2] ppc/amigaone: Allow running AmigaOS without firmware image

[Cédric Le Goater]

On 11/28/23 02:47, Nicholas Piggin wrote:
> On Tue Nov 28, 2023 at 2:37 AM AEST, Cédric Le Goater wrote:
> > > I'm not sure, I don't think it's necessary if your minimal patch works.
> > >
> > > I'll do a PR for 8.2 for SLOF and Skiboot updates, so happy to include
> > > this as well.
> >
> > I think this is a bit late for 8.2 to change FW images, well, at least
> > SLOF and skiboot. Are the new versions fixing something critical ?
>
> Ah okay. Well then I can put them in next instead.
>
> SLOF has a fix for virtio console over reboots, pretty minimal.

I see that commit dd4d4ea0add9 has :

  Fixes: cf28264 ("virtio-serial: Rework shutdown sequence")

Looks good for 8.2

> skiboot has some bug fixes but it's a bigger change and maybe not
> so important for QEMU.> Could they be merged in next release 

yes. it seems skiboot should be merged with chiptod support in 9.0.

> and SLOF tagged with stable?
>
> I think this amigaone patch could still be merged since it's only
> touching a new machine and it's fixing an issue of missing firmware.

ARM does something similar with roms. See hw/arm/boot.c file.

It will need a "Fixes" tag.

Thanks,

C.