qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] ppc/amigaone: Allow running AmigaOS without firmware imag


From: BALATON Zoltan
Subject: Re: [PATCH v3] ppc/amigaone: Allow running AmigaOS without firmware image
Date: Thu, 30 Nov 2023 14:18:16 +0100 (CET)

On Thu, 30 Nov 2023, Nicholas Piggin wrote:
On Thu Nov 30, 2023 at 8:49 AM AEST, BALATON Zoltan wrote:
On Tue, 28 Nov 2023, Cédric Le Goater wrote:
On 11/28/23 02:32, BALATON Zoltan wrote:
The machine uses a modified U-Boot under GPL license but the sources
of it are lost with only a binary available so it cannot be included
in QEMU. Allow running without the firmware image which can be used
when calling a boot loader directly and thus simplifying booting
guests. We need a small routine that AmigaOS calls from ROM which is
added in this case to allow booting AmigaOS without external firmware
image.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Since this is 8.2 material :


Fixes: d9656f860a38 ("hw/ppc: Add emulation of AmigaOne XE board")

This has missed rc2 but I hope there still will be a pull request before
rc3 which is the last chance now. I've sent a v4 which simpilifies the

Sigh, yes a few hiccups but I will send a PR with your v3 and a SLOF
update.

inserted code as I've found there's no need to do it like in the rom as
the only place it's called from just cares about the result.

I forgot the Fixes tag again, sorry, but the one above is still the same.

That's okay I added it. I'll just keep v3 since I have done some
tests with it. If it matches the the old rom then it seems like
a good starting point anyway, can always patch it later.

The only change is the code in it so it should not change any test results but v3 could work too, it just now seems unnecessary to include that much code when the short version is the same. Anyway, eiher v3 or v4 is OK.

Regards,
BALATON Zoltan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]