[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_ni
|
From: |
David Woodhouse |
|
Subject: |
Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices() |
|
Date: |
Fri, 26 Jan 2024 13:56:13 +0000 |
|
User-agent: |
Evolution 3.44.4-0ubuntu2 |
On Fri, 2024-01-26 at 14:45 +0100, Thomas Huth wrote:
> I think the nicest compromise is to add the "Error **errp" to the
> pc_init_ne2k_isa() and change the caller to pass in &error_fatal there ...
> further clean-up (passing the error even up further in the stack) is out of
> scope of this series, indeed.
Yep. That's what I've done in my tree at
https://git.infradead.org/users/dwmw2/qemu.git/commitdiff/ec5be4aaf6d2
I've fixed up the LASI NIC support, and I'm now looking into what you
said about nd->model (I don't think it matters, but I'm checking).
smime.p7s
Description: S/MIME cryptographic signature
- [PATCH v3 40/46] hw/s390x/s390-virtio-ccw: use qemu_create_nic_device(), (continued)
[PATCH v3 33/46] hw/m68k/q800: use qemu_find_nic_info(), David Woodhouse, 2024/01/08
[PATCH v3 46/46] net: make nb_nics and nd_table[] static in net/net.c, David Woodhouse, 2024/01/08
[PATCH v3 44/46] hw/pci: remove pci_nic_init_nofail(), David Woodhouse, 2024/01/08
[PATCH v3 26/46] hw/net/lan9118: use qemu_configure_nic_device(), David Woodhouse, 2024/01/08
[PATCH v3 25/46] hw/net/smc91c111: use qemu_configure_nic_device(), David Woodhouse, 2024/01/08
[PATCH v3 08/46] hw/arm/sbsa-ref: use pci_init_nic_devices(), David Woodhouse, 2024/01/08
[PATCH v3 41/46] hw/sparc/sun4m: use qemu_find_nic_info(), David Woodhouse, 2024/01/08
[PATCH v3 28/46] hw/arm/npcm7xx: use qemu_configure_nic_device, allow emc0/emc1 as aliases, David Woodhouse, 2024/01/08