Re: [PATCH v3 37/46] hw/net/lasi_i82596: use qemu_configure_nic_device()

[Thomas Huth]

On 08/01/2024 21.27, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
>   hw/net/lasi_i82596.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/net/lasi_i82596.c b/hw/net/lasi_i82596.c
> index 6a3147fe2d..2bb4f2c4ca 100644
> --- a/hw/net/lasi_i82596.c
> +++ b/hw/net/lasi_i82596.c
> @@ -125,11 +125,10 @@ SysBusI82596State *lasi_82596_init(MemoryRegion 
> *addr_space,
>       static const MACAddr HP_MAC = {
>           .a = { 0x08, 0x00, 0x09, 0xef, 0x34, 0xf6 } };
>   
> -    qemu_check_nic_model(&nd_table[0], TYPE_LASI_82596);
>       dev = qdev_new(TYPE_LASI_82596);
>       s = SYSBUS_I82596(dev);
>       s->state.irq = lan_irq;
> -    qdev_set_nic_properties(dev, &nd_table[0]);
> +    qemu_configure_nic_device(dev, true, NULL);
>       sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
>       s->state.conf.macaddr = HP_MAC; /* set HP MAC prefix */

Reviewed-by: Thomas Huth <thuth@redhat.com>