Re: [PATCH 01/13] ppc: Drop support for POWER9 and POWER10 DD1 chips

[Harsh Prateek Bora]

On 3/12/24 14:29, Nicholas Piggin wrote:
> On Tue Mar 12, 2024 at 2:55 PM AEST, Harsh Prateek Bora wrote:
> > On 3/12/24 10:20, Harsh Prateek Bora wrote:
> > > On 3/12/24 00:21, Nicholas Piggin wrote:
> > > > The POWER9 DD1 and POWER10 DD1 chips are not public and are no longer of
> > > > any use in QEMU. Remove them.
> > > >
> > > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > > > ---
> > > >    hw/ppc/spapr_cpu_core.c |  2 --
> > > >    target/ppc/cpu-models.c |  4 ----
> > > >    target/ppc/cpu_init.c   |  7 ++-----
> > > >    target/ppc/kvm.c        | 11 -----------
> > > >    4 files changed, 2 insertions(+), 22 deletions(-)
> > >
> > > Do we want to squash in removal of the macro as well?
> >
> > <snip>
> > Actually both, correcting diff:
> >
> > diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h
> > index 0229ef3a9a..7d89b41214 100644
> > --- a/target/ppc/cpu-models.h
> > +++ b/target/ppc/cpu-models.h
> > @@ -348,11 +348,9 @@ enum {
> >        CPU_POWERPC_POWER8NVL_BASE     = 0x004C0000,
> >        CPU_POWERPC_POWER8NVL_v10      = 0x004C0100,
> >        CPU_POWERPC_POWER9_BASE        = 0x004E0000,
> > -    CPU_POWERPC_POWER9_DD1         = 0x004E1100,
> >        CPU_POWERPC_POWER9_DD20        = 0x004E1200,
> >        CPU_POWERPC_POWER9_DD22        = 0x004E1202,
> >        CPU_POWERPC_POWER10_BASE       = 0x00800000,
> > -    CPU_POWERPC_POWER10_DD1        = 0x00801100,
> >        CPU_POWERPC_POWER10_DD20       = 0x00801200,
> >        CPU_POWERPC_970_v22            = 0x00390202,
> >        CPU_POWERPC_970FX_v10          = 0x00391100,
>
> That would make sense, but we do seem to use this list as somewhat of a
> reference or at least historic graveyard too (note all the other CPUs we
> no longer support). So I was going to just leave them there.

Oh ok, in that case, it's fine.

regards,
Harsh
> Thanks,
> Nick