Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4970e0da25 target/riscv: Remaining rvc insn reuse 32 bit translators
da1f3e3750 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
a1bf3ba5b9 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
1ecd7677af target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
b875bf8020 target/riscv: Convert @cs_2 insns to share translation functions
02d41b33a9 target/riscv: Remove decode_RV32_64G()
0a8a289053 target/riscv: Remove gen_system()
43db899c10 target/riscv: Rename trans_arith to gen_arith
9169852bf6 target/riscv: Remove manual decoding of RV32/64M insn
2343c176ea target/riscv: Remove shift and slt insn manual decoding
f09be7e1d6 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
b8c8e71abd target/riscv: Move gen_arith_imm() decoding into trans_* functions
14d0b8b743 target/riscv: Remove manual decoding from gen_store()
4c5dc279d6 target/riscv: Remove manual decoding from gen_load()
824e4f0e94 target/riscv: Remove manual decoding from gen_branch()
9ae02e8e09 target/riscv: Remove gen_jalr()
e39f61eb60 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
fdc41b9f43 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
d3b4c466b3 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
2efb6e31ed target/riscv: Convert RV priv insns to decodetree
74b6adaf30 target/riscv: Convert RV64D insns to decodetree
b7d0ee721d target/riscv: Convert RV32D insns to decodetree
f45fe63ecd target/riscv: Convert RV64F insns to decodetree
281a6771a1 target/riscv: Convert RV32F insns to decodetree
4ac2f5f9a9 target/riscv: Convert RV64A insns to decodetree
7059369fb1 target/riscv: Convert RV32A insns to decodetree
c6415d8f70 target/riscv: Convert RVXM insns to decodetree
e5f8a73b10 target/riscv: Convert RVXI csr insns to decodetree
a3918d697a target/riscv: Convert RVXI fence insns to decodetree
f9bc9a8e5a target/riscv: Convert RVXI arithmetic insns to decodetree
72eda7dfe6 target/riscv: Convert RV64I load/store insns to decodetree
0328135453 target/riscv: Convert RV32I load/store insns to decodetree
e65c22f552 target/riscv: Convert RVXI branch insns to decodetree
b06b60dc08 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit b06b60dc086a (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit e65c22f55253 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 0328135453ab (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 72eda7dfe6ab (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit f9bc9a8e5aff (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit a3918d697ab0 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit e5f8a73b10fd (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit c6415d8f70b7 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 7059369fb123 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 4ac2f5f9a9bc (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit 281a6771a143 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit f45fe63ecd4d (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit b7d0ee721d7a (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 74b6adaf3046 (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit 2efb6e31ed28 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit d3b4c466b346 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit fdc41b9f436c (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit e39f61eb6007 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 9ae02e8e0902 (target/riscv: Remove gen_jalr())
20/34 Checking commit 824e4f0e94b2 (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 4c5dc279d608 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 14d0b8b743d2 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit b8c8e71abd0a (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit f09be7e1d6be (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit 2343c176ea14 (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit 9169852bf6df (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 43db899c1016 (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 0a8a289053f2 (target/riscv: Remove gen_system())
29/34 Checking commit 02d41b33a991 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit b875bf80200a (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 1ecd7677afef (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit a1bf3ba5b93d (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit da1f3e3750d3 (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 4970e0da25eb (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden