Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1b358aa13f target/riscv: Remaining rvc insn reuse 32 bit translators
66cbd8997f target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
b9b30047d8 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
7121a134b0 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
35070e7e89 target/riscv: Convert @cs_2 insns to share translation functions
34b5aa251b target/riscv: Remove decode_RV32_64G()
0e5ffcf2e7 target/riscv: Remove gen_system()
2fcff73aa6 target/riscv: Rename trans_arith to gen_arith
018d544430 target/riscv: Remove manual decoding of RV32/64M insn
b8c2713f2a target/riscv: Remove shift and slt insn manual decoding
0ff74e10cb target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
071e341603 target/riscv: Move gen_arith_imm() decoding into trans_* functions
b7cbbf58d2 target/riscv: Remove manual decoding from gen_store()
8bba1273b3 target/riscv: Remove manual decoding from gen_load()
7a4990291c target/riscv: Remove manual decoding from gen_branch()
a652749d9e target/riscv: Remove gen_jalr()
a47421cba2 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
9e07bdd4ba target/riscv: Convert quadrant 1 of RVXC insns to decodetree
08a47610c5 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
416a23688c target/riscv: Convert RV priv insns to decodetree
8329afd789 target/riscv: Convert RV64D insns to decodetree
45bc6de0a2 target/riscv: Convert RV32D insns to decodetree
0ce7e82bb5 target/riscv: Convert RV64F insns to decodetree
823c63ebf0 target/riscv: Convert RV32F insns to decodetree
e476e5fc78 target/riscv: Convert RV64A insns to decodetree
28096a518e target/riscv: Convert RV32A insns to decodetree
7ae028f18b target/riscv: Convert RVXM insns to decodetree
cdef25ca90 target/riscv: Convert RVXI csr insns to decodetree
4a5b58cad4 target/riscv: Convert RVXI fence insns to decodetree
df5a8a0f0b target/riscv: Convert RVXI arithmetic insns to decodetree
520a45f4be target/riscv: Convert RV64I load/store insns to decodetree
04904238b2 target/riscv: Convert RV32I load/store insns to decodetree
287fecbc36 target/riscv: Convert RVXI branch insns to decodetree
6748037cd4 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 6748037cd4ed (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit 287fecbc3628 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 04904238b253 (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 520a45f4be9f (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit df5a8a0f0b0c (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit 4a5b58cad488 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit cdef25ca901a (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 7ae028f18b79 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 28096a518e25 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit e476e5fc78dc (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit 823c63ebf048 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit 0ce7e82bb54b (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit 45bc6de0a2b0 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 8329afd78925 (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit 416a23688cf6 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit 08a47610c5a4 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 9e07bdd4bad1 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit a47421cba21a (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit a652749d9ece (target/riscv: Remove gen_jalr())
20/34 Checking commit 7a4990291c3d (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 8bba1273b3d7 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit b7cbbf58d27c (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 071e3416031c (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 0ff74e10cbeb (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit b8c2713f2a48 (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit 018d54443056 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 2fcff73aa6ee (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 0e5ffcf2e712 (target/riscv: Remove gen_system())
29/34 Checking commit 34b5aa251b7e (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit 35070e7e8977 (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 7121a134b04b (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit b9b30047d81b (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit 66cbd8997f2f (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 1b358aa13f6a (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden