qemu-riscv
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] RISC-V: Add a missing "," in riscv_excp_names


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] RISC-V: Add a missing "," in riscv_excp_names
Date: Thu, 5 Mar 2020 18:19:10 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 3/5/20 5:48 PM, Palmer Dabbelt wrote:
THis would almost certainly cause the exception names to be reported
incorrectly.  Covarity found the issue (CID 1420223).  As per Peter's

"This", "Coverity" typos.

Fixes: ab67a1d07a4
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

suggestion, I've also added a comma at the end of the list to avoid the issue
reappearing in the future.

Signed-off-by: Palmer Dabbelt <address@hidden>
---
  target/riscv/cpu.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index c47d10b739..c0b7023100 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -66,7 +66,7 @@ const char * const riscv_excp_names[] = {
      "exec_page_fault",
      "load_page_fault",
      "reserved",
-    "store_page_fault"
+    "store_page_fault",
      "reserved",
      "reserved",
      "reserved",
@@ -74,7 +74,7 @@ const char * const riscv_excp_names[] = {
      "guest_exec_page_fault",
      "guest_load_page_fault",
      "reserved",
-    "guest_store_page_fault"
+    "guest_store_page_fault",
  };
const char * const riscv_intr_names[] = {





reply via email to

[Prev in Thread] Current Thread [Next in Thread]