[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/8] target/riscv: 128-bit support for some csrs
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 7/8] target/riscv: 128-bit support for some csrs |
|
Date: |
Mon, 30 Aug 2021 20:43:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 8/30/21 10:16 AM, Frédéric Pétrot wrote:
target/riscv/utils_128.h | 173 ++++++++++++++++
You should extend include/qemu/int128.h as needed, rather than this.
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 4321b03b94..0d18055e08 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -26,6 +26,7 @@
#include "fpu/softfloat-types.h"
#include "qom/object.h"
+#include "utils_128.h"
And anyway, it's certainly not needed in cpu.h.
@@ -60,19 +61,6 @@
#define RV64 ((target_ulong)2 << (TARGET_LONG_BITS - 2))
/* To be used on misah, the upper part of misa */
#define RV128 ((target_ulong)3 << (TARGET_LONG_BITS - 2))
-/*
- * Defined to force the use of tcg 128-bit arithmetic
- * if the compiler does not have a 128-bit built-in type
- */
-#define SOFT_128BIT
-/*
- * If available and not explicitly disabled,
- * use compiler's 128-bit integers.
- */
-#if defined(__SIZEOF_INT128__) && !defined(SOFT_128BIT)
-#define HARD_128BIT
-#endif
You shouldn't have added these earlier and remove them here. Of course, I don't think
they're needed at all.
r~
[PATCH 6/8] target/riscv: Support of compiler's 128-bit integer types, Frédéric Pétrot, 2021/08/30
[PATCH 5/8] target/riscv: 128-bit multiply and divide, Frédéric Pétrot, 2021/08/30
[PATCH 8/8] target/riscv: Support for 128-bit satp, Frédéric Pétrot, 2021/08/30
[PATCH 7/8] target/riscv: 128-bit support for some csrs, Frédéric Pétrot, 2021/08/30
- Re: [PATCH 7/8] target/riscv: 128-bit support for some csrs,
Richard Henderson <=
Re: [PATCH 1/8] target/riscv: Settings for 128-bit extension support, Alistair Francis, 2021/08/30