Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions

From:	Richard Henderson
Subject:	Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions
Date:	Mon, 30 Aug 2021 20:32:53 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 8/30/21 2:38 PM, Philippe Mathieu-Daudé wrote:

+#if defined(TARGET_RISCV128)
+        if (is_128bit(ctx)) {


Maybe this could allow the compiler eventually elide the
code and avoid superfluous #ifdef'ry:

            if (TARGET_LONG_BITS >= 128) {


TCG does not support TARGET_LONG_BITS != {32,64}.
This will not work.

But is_128bit() should be sufficient in each opcode, because that itself should evaluateto false if unsupported.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 2/8] target/riscv: 128-bit registers creation and access, (continued)
- [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions, Frédéric Pétrot, 2021/08/30
  - Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions, Philippe Mathieu-Daudé, 2021/08/30
  - Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions, Richard Henderson, 2021/08/30
    - Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions, Frédéric Pétrot, 2021/08/31
  - Re: [PATCH 3/8] target/riscv: Addition of 128-bit ldu, lq and sq instructions, Richard Henderson, 2021/08/30
- [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions, Frédéric Pétrot, 2021/08/30
  - Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions, Philippe Mathieu-Daudé, 2021/08/30
    - Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions, Philippe Mathieu-Daudé, 2021/08/30
    - Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions, Frédéric Pétrot, 2021/08/31
    - Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions, Richard Henderson <=
  - Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions, Richard Henderson, 2021/08/30
- [PATCH 6/8] target/riscv: Support of compiler's 128-bit integer types, Frédéric Pétrot, 2021/08/30
  - Re: [PATCH 6/8] target/riscv: Support of compiler's 128-bit integer types, Richard Henderson, 2021/08/30
- [PATCH 5/8] target/riscv: 128-bit multiply and divide, Frédéric Pétrot, 2021/08/30
- [PATCH 8/8] target/riscv: Support for 128-bit satp, Frédéric Pétrot, 2021/08/30
- [PATCH 7/8] target/riscv: 128-bit support for some csrs, Frédéric Pétrot, 2021/08/30
  - Re: [PATCH 7/8] target/riscv: 128-bit support for some csrs, Richard Henderson, 2021/08/30
- Re: [PATCH 1/8] target/riscv: Settings for 128-bit extension support, Alistair Francis, 2021/08/30
  - Re: [PATCH 1/8] target/riscv: Settings for 128-bit extension support, Frédéric Pétrot, 2021/08/31

Prev by Date: Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions
Next by Date: Re: [PATCH 6/8] target/riscv: Support of compiler's 128-bit integer types
Previous by thread: Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions
Next by thread: Re: [PATCH 4/8] target/riscv: 128-bit arithmetic and logic instructions
Index(es):
- Date
- Thread