Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(

From:	Daniel Henrique Barboza
Subject:	Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Date:	Mon, 27 Mar 2023 15:59:32 -0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0



On 3/27/23 15:43, Richard Henderson wrote:

On 3/27/23 05:42, Daniel Henrique Barboza wrote:

+        g_autofree char *name = g_strdup_printf("%s", misa_cfg->name);
+        g_autofree char *desc = g_strdup_printf("%s", misa_cfg->description);


What is the point of this?  It would seem that you could simply pass the 
original string literals to object_property_*.


Yeah, it appears that every other object_property_add() is being called using
the literals without dealing with g_autofree.

I'll change it in v2.

Daniel

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/19] remove MISA ext_N flags from cpu->cfg, Daniel Henrique Barboza, 2023/03/27
- [PATCH 01/19] target/riscv: sync env->misa_ext* with cpu->cfg in realize(), Daniel Henrique Barboza, 2023/03/27
- [PATCH 02/19] target/riscv: remove MISA properties from isa_edata_arr[], Daniel Henrique Barboza, 2023/03/27
- [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Daniel Henrique Barboza, 2023/03/27
  - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Richard Henderson, 2023/03/27
    - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Daniel Henrique Barboza <=
  - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Richard Henderson, 2023/03/27
    - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Daniel Henrique Barboza, 2023/03/27
    - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Richard Henderson, 2023/03/27
- [PATCH 04/19] target/riscv: remove cpu->cfg.ext_a, Daniel Henrique Barboza, 2023/03/27
- [PATCH 05/19] target/riscv: remove cpu->cfg.ext_c, Daniel Henrique Barboza, 2023/03/27
- [PATCH 06/19] target/riscv: remove cpu->cfg.ext_d, Daniel Henrique Barboza, 2023/03/27
- [PATCH 07/19] target/riscv: remove cpu->cfg.ext_f, Daniel Henrique Barboza, 2023/03/27
- [PATCH 08/19] target/riscv: remove cpu->cfg.ext_i, Daniel Henrique Barboza, 2023/03/27
- [PATCH 09/19] target/riscv: remove cpu->cfg.ext_e, Daniel Henrique Barboza, 2023/03/27
- [PATCH 10/19] target/riscv: remove cpu->cfg.ext_m, Daniel Henrique Barboza, 2023/03/27

Prev by Date: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Next by Date: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Previous by thread: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Next by thread: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Index(es):
- Date
- Thread