Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(

From:	Richard Henderson
Subject:	Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Date:	Mon, 27 Mar 2023 15:27:49 -0700
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 3/27/23 15:15, Daniel Henrique Barboza wrote:



On 3/27/23 15:52, Richard Henderson wrote:

On 3/27/23 05:42, Daniel Henrique Barboza wrote:

+static void cpu_set_misa_ext_cfg(Object *obj, Visitor *v, const char *name,
+                                 void *opaque, Error **errp)
+{
+    RISCVCPUMisaExtConfig *misa_ext_cfg = opaque;


const

+static void cpu_get_misa_ext_cfg(Object *obj, Visitor *v, const char *name,
+                                 void *opaque, Error **errp)
+{
+    RISCVCPUMisaExtConfig *misa_ext_cfg = opaque;


const

+static RISCVCPUMisaExtConfig misa_ext_cfgs[] = {};


const


It seems that I can't use 'const' because the object_property_add() API uses a 
'void *opaque'
pointer and it won't take a "const RISCVCPUMisaExtConfig *":

../target/riscv/cpu.c:1454:35: error: passing argument 7 of ‘object_property_add’ discards‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]

  1454 |                             NULL, misa_cfg);
       |                                   ^~~~~~~~

You can cast away the const. There's no need for this array to be outside of .rodata (or.data.rel.ro).

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 00/19] remove MISA ext_N flags from cpu->cfg, Daniel Henrique Barboza, 2023/03/27
- [PATCH 01/19] target/riscv: sync env->misa_ext* with cpu->cfg in realize(), Daniel Henrique Barboza, 2023/03/27
- [PATCH 02/19] target/riscv: remove MISA properties from isa_edata_arr[], Daniel Henrique Barboza, 2023/03/27
- [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Daniel Henrique Barboza, 2023/03/27
  - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Richard Henderson, 2023/03/27
    - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Daniel Henrique Barboza, 2023/03/27
  - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Richard Henderson, 2023/03/27
    - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Daniel Henrique Barboza, 2023/03/27
    - Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties(), Richard Henderson <=
- [PATCH 04/19] target/riscv: remove cpu->cfg.ext_a, Daniel Henrique Barboza, 2023/03/27
- [PATCH 05/19] target/riscv: remove cpu->cfg.ext_c, Daniel Henrique Barboza, 2023/03/27
- [PATCH 06/19] target/riscv: remove cpu->cfg.ext_d, Daniel Henrique Barboza, 2023/03/27
- [PATCH 07/19] target/riscv: remove cpu->cfg.ext_f, Daniel Henrique Barboza, 2023/03/27
- [PATCH 08/19] target/riscv: remove cpu->cfg.ext_i, Daniel Henrique Barboza, 2023/03/27
- [PATCH 09/19] target/riscv: remove cpu->cfg.ext_e, Daniel Henrique Barboza, 2023/03/27
- [PATCH 10/19] target/riscv: remove cpu->cfg.ext_m, Daniel Henrique Barboza, 2023/03/27
- [PATCH 11/19] target/riscv: remove cpu->cfg.ext_s, Daniel Henrique Barboza, 2023/03/27
- [PATCH 12/19] target/riscv: remove cpu->cfg.ext_u, Daniel Henrique Barboza, 2023/03/27
- [PATCH 13/19] target/riscv: remove cpu->cfg.ext_h, Daniel Henrique Barboza, 2023/03/27

Prev by Date: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Next by Date: [PATCH v2 00/19] remove MISA ext_N flags from cpu->cfg
Previous by thread: Re: [PATCH 03/19] target/riscv: introduce riscv_cpu_add_misa_properties()
Next by thread: [PATCH 04/19] target/riscv: remove cpu->cfg.ext_a
Index(es):
- Date
- Thread