|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v3 4/7] hw/isa/piix{3, 4}: QOM'ify PCI device creation and wiring |
Date: | Mon, 30 May 2022 15:17:12 +0200 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
Hi Bernhard, On 28/5/22 21:20, Bernhard Beschow wrote:
PCI interrupt wiring and device creation (piix4 only) were performed in create() functions which are obsolete. Move these tasks into QOM functions to modernize the code. In order to avoid duplicate checking for xen_enabled() the piix3 realize methods are now split. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- hw/isa/piix3.c | 67 +++++++++++++++++++++++++++++++++----------------- hw/isa/piix4.c | 30 ++++++++++++++++------ 2 files changed, 67 insertions(+), 30 deletions(-)
While this is the same chipset family, these models are maintained by different people... Do you mind splitting? For PIIX4 part: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[Prev in Thread] | Current Thread | [Next in Thread] |