qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/7] include/hw/southbridge/piix: Aggregate all PIIX sough


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 1/7] include/hw/southbridge/piix: Aggregate all PIIX soughbridge type names
Date: Mon, 30 May 2022 15:19:33 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1

On 29/5/22 20:09, Bernhard Beschow wrote:
On Sun, May 29, 2022 at 11:05 AM Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk <mailto:mark.cave-ayland@ilande.co.uk>> wrote:

    On 28/05/2022 20:20, Bernhard Beschow wrote:

     > TYPE_PIIX3_PCI_DEVICE resides there as already, so add the remaining
     > ones, too.
     >
     > Signed-off-by: Bernhard Beschow <shentey@gmail.com
    <mailto:shentey@gmail.com>>
     > Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk
    <mailto:mark.cave-ayland@ilande.co.uk>>
     > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org
    <mailto:f4bug@amsat.org>>
     > ---
     >   hw/isa/piix3.c                | 3 ---
     >   include/hw/isa/isa.h          | 2 --
     >   include/hw/southbridge/piix.h | 4 ++++
     >   3 files changed, 4 insertions(+), 5 deletions(-)

    One tiny nit here: there's a typo in the subject line which I missed
    when reviewing v2.

    s/soughbridge/southbridge/


Ack. Will fix in v3.

Can do. Also, "include/" in subject is not helpful.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]