Re: Bug report (was Re: [RP] Maximizing a window (or a frame?))

[Shawn Betts]

Rupert <address@hidden> writes:

> On Tue, Mar 25, 2003 at 02:16:10PM -0600, Jay Belanger wrote:
> > 
> > Other things to look at:
> > remove:   (bound to C-t R) kill the current frame, adjusting the others as
> >           appropriate
> > resize:   (bound to C-t r) resize the current frame.  
> >           C-p/C-n to shrink/grow vertically,
> >           C-b/C-f to shrink/grow horizontally
> >           RET to finish                
> 
> This is nice to know -- thanks for pointing out the remove and resize
> features. One problem I've noticed is that ratpoison segfaults if I
> ask it to remove when there's only one frame or just the root window
> visible. The code in actions.c that appears to be faulty is:
> 
> char *
> cmd_remove (int interactive, void *data)
> {
>   rp_window_frame *frame;
> 
>   frame = find_frame_next (current_screen()->rp_current_frame);
> 
>   if (frame)
>     {
>       ...
>     }
> 
> frame is always non-null, even if there's just one frame or only
> the desktop visible.

Hi Rupert,

Thanks for the report. What version is this in?

Shawn