ratpoison-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RP] 1.4.7-beta: new features


From: Ellington Santos
Subject: Re: [RP] 1.4.7-beta: new features
Date: Tue, 4 Jun 2013 15:12:45 -0300

Thanks! It works!

I don't know if you are the maintainer, but sloppy.c gives a warning:

address@hidden:~/downloads/rat$ gcc -g -Wall -O2  -I/usr/X11R6/include -o sloppy sloppy.c -L/usr/X11R6/lib -lX11
sloppy.c: In function ‘spawn’:
sloppy.c:47:7: warning: missing sentinel in function call [-Wformat=]
       execl("/bin/sh", "sh", "-c", cmd, 0);
       ^

To correct:

-      execl("/bin/sh", "sh", "-c", cmd, 0);
+      execl("/bin/sh", "sh", "-c", cmd, (char *)0);

I know it isn't to much, but it's my fifty cents for while. ;-)




On Tue, Jun 4, 2013 at 1:35 PM, Jérémie Courrèges-Anglas <address@hidden> wrote:
Ellington Santos <address@hidden> writes:

> Jérémie,
>
> Thanks for you efforts! Since I saw ratpoison, i was beloved! I always use
> latest version in my notebook.

Don't thank me, I did nothing but break stuff. :)

> I got a bug: ratpoison dies after a frestore:
>
> ratpoison -c 'frestore $(ratpoison -c fdump)'
> ratpoison:main.c:178: error: strtok_ws() called but not initalized, this is
> a *BUG*

See, I don't even know how to program... :P
More seriously, this, in strtok_ws, should be enough to fix it:

-  if (s == NULL)
+  if (s != NULL)

I've just pushed it to savannah.  If you see other problems, please
don't hesitate.

> Thank you for all again.
>
> Elllington Santos

Thank you!

Note: 1.4.6 users, your version isn't affected.
--
Jérémie Courrèges-Anglas
PGP Key fingerprint: 61DB D9A0 00A4 67CF 2A90  8961 6191 8FBF 06A1 1494


reply via email to

[Prev in Thread] Current Thread [Next in Thread]