speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] rename fdsetconv.c to spd_conv.c and move fdsetconv.h to spd


From: William Hubbs
Subject: [PATCH 1/2] rename fdsetconv.c to spd_conv.c and move fdsetconv.h to spd_utils.h
Date: Sat, 2 Oct 2010 17:54:14 -0500

Hi Andrei,

On Thu, Sep 30, 2010 at 10:27:57PM +0200, Andrei Kholodnyi wrote:
> fdsetconv was renamed to spd_conv.c to align naming in common dir
> since spd_utils.h is used as a header for common dir,
> put content of fdsetconv.h to this header

I'm fine with the first part of this (renaming fdsetconv.c to
spd_conv.c), but I would prefer not to have a spd_utils.h that contains
everything from the common library.

I think we should have an spd_conv.h, rename spd_utils.h to
spd_getline.h, and maybe rename speechd_types.h to spd_types.h.
That way we have a source and an include file for each type of function
in the common library.

What do you think?

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101002/c0db3cc6/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]