[PATCH 1/2] rename fdsetconv.c to spd_conv.c and move fdsetconv.h to spd_utils.h

[Andrei Kholodnyi]

patch dropped

On 10/3/10, William Hubbs <w.d.hubbs at gmail.com> wrote:
> Hi Andrei,
>
> On Thu, Sep 30, 2010 at 10:27:57PM +0200, Andrei Kholodnyi wrote:
>> fdsetconv was renamed to spd_conv.c to align naming in common dir
>> since spd_utils.h is used as a header for common dir,
>> put content of fdsetconv.h to this header
>
> I'm fine with the first part of this (renaming fdsetconv.c to
> spd_conv.c), but I would prefer not to have a spd_utils.h that contains
> everything from the common library.
>
> I think we should have an spd_conv.h, rename spd_utils.h to
> spd_getline.h, and maybe rename speechd_types.h to spd_types.h.
> That way we have a source and an include file for each type of function
> in the common library.
>
> What do you think?
>
> William
>
>

-- 
Sent from my mobile device

Believe is not enough, you must know