speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 03/09] replace EPunctMode with SPDPunctuation


From: Andrei Kholodnyi
Subject: [PATCH 03/09] replace EPunctMode with SPDPunctuation
Date: Sun, 3 Oct 2010 21:48:53 +0200

> speechd_types.h is for data types that are shared between the server and
> modules. ?I feel that merging the data types from the API into this file
> as well breaks the separation that we need to keep between the code for
> the API and the rest of the project. ?Also it makes keeping the API's
> current/revision/age numbers correct confusing at best.

> the separation that we need to keep between the code for the API and the rest 
> of the project.

Could you please explain what does this "separation" mean and why do
you need this "separation"?
IMO we do not need it at all, since these are the same data moving
back and forth.

you have
data 1 (client) -> marshaling- > demarshaling -> data 2 (server)
data 1 = data2 is the same data.
at the moment the same data (data 1 and data 2) in the speech-dispatcher
are represented by different data types on client/server side.
e.g. SPDPunctuation/EPunctMode, SPDPriority/int and so on.
And this makes no sense to me.

If I'd follow your "separation needs" I'd expect e.g. having different
data types e.g. by socket programming on client/server side.
But they are the same, William.

I have SPDPunctuation data on my client side,
I send it over network to the server, it arrives on the server side,
what type of data should I expect to get?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]