[PATCH] rework default audio output method

[William Hubbs]

On Wed, Dec 08, 2010 at 08:06:21AM +0100, Bohdan R. Rau wrote:
> On Wed,  8 Dec 2010 00:38:32 -0600, William Hubbs <w.d.hubbs at gmail.com>
> wrote:
> [...]
> > +AC_ARG_WITH([default-audio-method],
> > +   [AS_HELP_STRING([--with-default-audio-method=<name>],
> > +           [defines default audio method (default - first discovered)])],
> > +   [default_audio_method="$withval"],
> > +   [])
> > +AC_MSG_NOTICE([Default audio method is $default_audio_method])
> > +AC_SUBST([default_audio_method])
> 
> For me there must be some check to prevent setting of default_audio_method
> into something unusable.

I'm not sure what you mean by "unusable". The code as it currently
stands assumes that if you set the argument from the command line you
know what you are doing and doesn't protest if you set it to something
that is not an audio output method in our tree.

We are planning to move to audio plugins like we had in OpenTTS
so allowing names in the default that are not methods
in our tree is fine.

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20101208/404dcb18/attachment-0001.pgp>