speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

WIP audio in server


From: Jeremy Whiting
Subject: WIP audio in server
Date: Fri, 17 Jun 2016 18:14:28 -0600

Luke,

I've attached a patch that implements stopping audio by sending STOP
NEWLINE to the audio socket. The audio server detects this in the same
way it detects ACK NEWLINE and asks the audio system to stop playback.
When I tested this with espeak output module stopping isn't immediate,
but when I tested with the pico output module it works fine. I wonder
if the espeak module is either a) sending all the audio faster than I
am able to send the stop with spd-say -S or b) not aknowledging the
stop command immediately for some other reason.

In working on this I'm slowly realizing it would be awesome to have
unit tests for all the different aspects of speech-dispatcher. We do
have some tests, but the ones I've seen depended on an installed
speech-dispatcher in order to run. making "make test" run them seems
to work, but depending on an installed system doesn't make sense when
we are updating code. I don't have a lot of experience setting up
tests with code from a working directory running as the server, but
will definitely look into how that is done in other similar projects,
since I think it would help quite a bit.

Anyway, let me know what you think of the patch. I created it from the
top of the wip/audio-in-server branch obviously.

thanks,
Jeremy

On Wed, Apr 13, 2016 at 9:09 AM, Jeremy Whiting <jpwhiting at kde.org> wrote:
> Luke,
>
> I agree with your interpretation of what I'm doing. I meant to have
> all audio processing handled in the thread. My understanding of glib
> and contexts and main loops etc. is definitely on a noob level. Most
> of what I wrote was copied from elsewhere in speechd itself. If you
> have time to fix/improve the patch by all means go for it. Let me know
> if you don't and I can take a look as I find time also though.
>
> thanks,
> Jeremy
>
> On Wed, Apr 13, 2016 at 12:40 AM, Luke Yelavich
> <luke.yelavich at canonical.com> wrote:
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-ability-to-stop-the-audio-by-sending-STOP-NEWL.patch
Type: text/x-patch
Size: 4748 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20160617/852239b3/attachment.bin>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]