Re: [Texmacs-dev] GCC-3.2 segfault and compilation fixes

[David Allouche]

On Wed, Jul 09, 2003 at 10:31:40AM +0200, David Allouche wrote:
> On Wed, Jul 09, 2003 at 10:29:36AM +0400, Igor V. Kovalenko wrote:
> > diff -ur TeXmacs-1.0.1.16-src-orig/src/common.makefile.in 
> > TeXmacs-1.0.1.16-src/src/common.makefile.in
> > --- TeXmacs-1.0.1.16-src-orig/src/common.makefile.in        2003-06-30 
> > 13:12:41.000000000 +0400
> > +++ TeXmacs-1.0.1.16-src/src/common.makefile.in     2003-07-03 
> > 22:54:33.000000000 +0400
> > @@ -220,7 +220,7 @@
> >  $(classes_obj): Objects/%.o: %.cpp
> >     $(call cxx_incl,$(classes_incl))
> >  $(data_obj): Objects/%.o: %.cpp
> > -   $(call cxx_incl,$(data_incl),-I$(tmsrc)/include)
> > +   $(call cxx_incl,$(data_incl) -I$(tmsrc)/include)
> >  $(edit_obj): Objects/%.o: %.cpp
> >     $(call cxx_incl,$(edit_incl))
> >  $(guile_obj): Objects/%.o: %.cpp
> 
> This is obviously a correct fix for a typo introduced in 1.0.1.16.

Correction: the _really_ correct fix is using the cxx_incl_sys
function (which does take two parameters) instead of cxx_incl.

The reason is that TeXmacs.h is included with "#include <TeXmacs.h>",
so it is more correct to put its include path option after a "-I-"
option (which is the value of the DASH_I_DASH variable except when the
compiler is not gcc).

-- 
                                                            -- ddaa