Re: [Tsp-devel] tsp ascii writer cannot write "char" data type

[Eric Noulard]

2009/5/12 Yves DUF <address@hidden>:
> Hello.
>
> 2009/5/11 Bettina TANOH <address@hidden>:
>> Hi everybody,
>>
>> I wanted to use tsp_ascii_writer to collect data of different types and I
>> noticed that data which type is "char" is not writen into the output file. I
>> looked for the problem into the code and I saw that the code line that
>> writes the "char" in a file is commented (source file "tsp_ascii_writer.c"
>> line 874). I am working on tsp version 0.8.3.
>> Why this line has been commented ?
>
> May be a bad merge since TSP was not handling well all different kind
> of types in the past ?
> Try to remove the comment, as it should works now.


The code you  are talking about in tsp_ascii_writer.c:874
is not **ALL** commented out the thing is "char" as such
(as far as I remember) is not handled that way in ascii_writer
which handle it as an array:

873  case TSP_TYPE_CHAR:
874    /*fprintf(sfile,fmt_tab[sample.type],sample.uvalue.char_value);*/
875    fprintf(sfile,fmt_tab[sample.type],tsp_ascii_writer_tab_char);
876   break;
877
878  case TSP_TYPE_UCHAR:
879   /*fprintf(sfile,fmt_tab[sample.type],sample.uvalue.uchar_value);*/
880    fprintf(sfile,fmt_tab[sample.type],tsp_ascii_writer_tab_uchar);
881   break;

I do NOT remember why it was done like that but looks like it was done
on purpose.

If you do have trouble with this, please could you gives us a testcase and ...

> If it's OK, send us the patch and it will be integrated in the next version.

even better a patch too, I totally agree with that :-)

With which kind of provider are working with?
Is it a blackboard one? is it a custom made?
...
-- 
Erk