[Wesnoth-patches] [patch #3671] additive bonus, multiplicative penalty damage calculations

[ott]

Follow-up Comment #1, patch #3671 (project wesnoth):

Here is a third version, this one just tweaking the current additive
calculations to factor in resistance right at the end (RATE).  I also attach
a vanilla beginning-of-scenario save for Mages and Elves to help people
playtest this patch, and a replay with the patch applied to have a look at.



See the forum thread for the comparative damage tables and more discussion. 
Briefly, the RATE method of calculating damage reduces excessive day/night
swings against high resistance units, but keeps damage identical or very
similar to the current method, in the majority of cases.  Moreover, it does
not have the 1.25*.75=0.9375 problem.



The only concern I would have with this method is that it increases led,
favourable time of day damage against defenders with high vulnerability to
the attack type.  The worst actual corner case is a Horseman with a
holy-water-treated lance in Valley of Death, led by an Elvish Marshal during
daytime, which would do 63 damage against Undead with this patch, against the
current 49.



Thanks to miq for the original resistances-at-the-end idea.
    _______________________________________________________

Additional Item Attachment:

File name: actions.cpp.resistlast.patch   Size:6 KB
diff -u against actions.cpp revision 1.185
<http://savannah.nongnu.org/patch/download.php?item_id=3671&item_file_id=4094>

    _______________________________________________________

This item URL is:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=3671>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/