xboard-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XBoard-devel] url detection [winboard]


From: h.g. muller
Subject: Re: [XBoard-devel] url detection [winboard]
Date: Sat, 10 Oct 2009 08:37:31 +0200


Just to let you know tonight I added a nice new feature to the winboard ICS window to detect urls and invoke browser/email/ftp client.

I've been wanting it for ages, and had some spare time tonight.

OK, great! But one point of order:

It seems like your commit makes tons of changes, which often look in the diff as replacing a line by an identical line! Presumibly this involves changing tabs into spaces or vice versa. I don't know if this was a conscious change or just a side effect of the IDE you used, put perhaps it would be an idea to somehow separate these changes from the actual URL detaction patch. (E.g. by committing an unmodified version of the previous winboard.c that has been
reformatted by the IDE, befr committing the actual patch.)

Currently it is virtually impossible to figure out what was patched.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]