Re: [XBoard-devel] url detection [winboard]

[Eric Mullins]

h.g. muller wrote:
> > Just to let you know tonight I added a nice new feature to the 
> > winboard ICS window to detect urls and invoke browser/email/ftp client.
> >
> > I've been wanting it for ages, and had some spare time tonight.
>
> OK, great! But one point of order:
>
> It seems like your commit makes tons of changes, which often look in 
> the diff as replacing a line by an identical line!
> Presumibly this involves changing tabs into spaces or vice versa. I 
> don't know if this was a conscious change or just
> a side effect of the IDE you used, put perhaps it would be an idea to 
> somehow separate these changes from the
> actual URL detaction patch. (E.g. by committing an unmodified version 
> of the previous winboard.c that has been
> reformatted by the IDE, befr committing the actual patch.)
>
> Currently it is virtually impossible to figure out what was patched.
Fixed.  What a pain-- took longer to fix that than implement it originally!

It was purely accidental.  I ran a tab removal routine that caused it.  
I had selected only a small block of text and thought the routine would 
only modify the selection instead of the whole file.  I certainly didn't 
want to remove tabs everywhere because doing so would convert them into 
4 spaces (my editor's tab setting is 4 which is rather unusual), so 
assuming an 8 width tab char, most of the file's indentation got reduced.