automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dirlist


From: Alexandre Duret-Lutz
Subject: Re: dirlist
Date: 20 Jul 2002 11:01:42 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7

Hi Chuck,

| How about a note there, which says "Reminder: acdir is not ordinarily
| used by end-users; it is used by automake's test suite".

sounds good

| +aclocalver=`(aclocal --version) 2>/dev/null | sed -n -e 1p | \
| +   gawk '{print $NF}' | sed -e 's/\.[^\.]*$//'` 

This will give bad results for single-dot versions like `1.6' or
`1.6a' (plus gawk is not available everywhere).  How about
something like

(aclocal --version) 2>/dev/null | \
  sed 's/^.* \([0-9][0-9]*\.[0-9][0-9]*[a-z]*\).*$/\1/;1q'

| +    libtool_found=no
| +    for d in $extra_includes $aclocaldir ; do
| +       if [ "x$d" != "x-I" ] && [ -f "$d/libtool.m4" ] ; then
| +          libtool_found=yes
| +       fi
| +    done
| +    test "x$libtool_found" = "xyes" || exit 77
| +    ACLOCAL="$ACLOCAL -I $srcdir/../m4 $extra_includes -I $aclocaldir"

No idea why this appends both `$extra_includes' and `-I $aclocaldir'.
Shouldn't we add only the directory where the macro was found?
I guess I'm missing something.
-- 
Alexandre Duret-Lutz




reply via email to

[Prev in Thread] Current Thread [Next in Thread]