Re: [gnugo-devel] Opponent follow-up value and group connection

[Paul Pogonyshev]

SP LEE wrote:
> This is a more careful treatment for larger dragons. Please ignore my
> previous patch. The fix here is like "forget the shape factor if either
> attacking or defending a dragon of more than 20 points is involved." This
> kind of play can be seen even in professional games.

a good idea, just only hardcoded values are something better to avoid,
as Evan mentioned.

> @@ -2636,7 +2636,9 @@
>      if (move[pos].secondary_value != 0.0)
>        TRACE("  %1m: %f - secondary\n", pos, 0.05 *
> move[pos].secondary_value);
>
> -    if (move[pos].numpos_shape + move[pos].numneg_shape > 0) {
> +    if ((move[pos].numpos_shape + move[pos].numneg_shape > 0)
> +  && (move[pos].territorial_value < 20)){
> +  /* for attack/defend large dragon, ignore shape factor */
>        /* shape_factor has already been computed. */
>        float old_value = tot_value;
>        tot_value *= shape_factor;

and two things about the patch's lookout:

- if your mail client wraps lines, better send patches attached
  (the same if it converts tabs to spaces)

- not a problem so far, but if you are going to work with gnu go,
  please use the coding conventions we do. this patch should look
  like

-    if (move[pos].numpos_shape + move[pos].numneg_shape > 0) {
+    /* For attack/defend of large dragons, ignore shape factor. */
+    if (move[pos].numpos_shape + move[pos].numneg_shape > 0.0
+        && move[pos].territorial_value < 20.0) {
       /* shape_factor has already been computed. */

  otherwise you force Gunnar or me or someone else to fix this sooner
  or later.

Paul