[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Minor testsuite size reduction.

From: Ralf Wildenhues
Subject: Re: [PATCH] Minor testsuite size reduction.
Date: Wed, 21 Jul 2010 19:54:30 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Eric Blake wrote on Wed, Jul 21, 2010 at 03:58:16PM CEST:
> * lib/autotest/general.m4 (AT_INIT) <serial testing>: Ensure
> at_jobs is 1.

> @@ -1440,6 +1458,7 @@ dnl         kill -13 $$
>    wait
>  else
>    # Run serially, avoid forks and other potential surprises.
> +  at_jobs=1
>    for at_group in $at_groups; do
>      at_fn_group_prepare
>      if cd "$at_group_dir" &&

Rereading this again, it wasn't right, though, or, put another way, I
think it causes potentially worse behavior in an unusual setting (not

Say you run './testsuite -jN' on a system without mkfifo, then at_quiet
gets set to : but above change later sets at_jobs to 1, causing
$at_desc_line to never be printed.

Sorry about leading you down there,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]