bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: glr.c cleanup


From: Paul Eggert
Subject: Re: glr.c cleanup
Date: Wed, 07 Dec 2005 12:16:25 -0800
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

Re <http://lists.gnu.org/archive/html/bison-patches/2005-12/msg00009.html>:

I have some qualms about some of the renaming in that patch, e.g.,
renaming "yystack" to "yystackp".

Personally I dislike Hungarian-style naming conventions
<http://en.wikipedia.org/wiki/Hungarian_notation> where the name of an
object tells you something about its type.  I find that it clutters up
the code, because the redundancy hurts more than it helps.

Paul Hilfinger wrote the GLR code, though, so he's a much better
arbiter of style in that area.  Paul, what do you think about that
patch?  Do you want suffix "p" to be used uniformly for pointers to
things?  Would you prefer to omit the "p"?  Or is it not that big a
deal for you?  Etc.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]