Re: glr.c cleanup

[Paul Hilfinger]

 > I have some qualms about some of the renaming in that patch, e.g.,
 > renaming "yystack" to "yystackp".
 > 
 > Personally I dislike Hungarian-style naming conventions
 > <http://en.wikipedia.org/wiki/Hungarian_notation> where the name of an
 > object tells you something about its type.  I find that it clutters up
 > the code, because the redundancy hurts more than it helps.
 > 
 > Paul Hilfinger wrote the GLR code, though, so he's a much better
 > arbiter of style in that area.  Paul, what do you think about that
 > patch?  Do you want suffix "p" to be used uniformly for pointers to
 > things?  Would you prefer to omit the "p"?  Or is it not that big a
 > deal for you?  Etc.

This particular instance of Hungarian notation is not all that
objectionable, since it seems to be used fairly frequently in other
GNU code I've seen (including some of mine).

However, I am having some trouble reviewing this patch.  It appears to
be against a slightly non-current version of glr.c.  Is that true?
Also, the patch appeared to contain an extra space before context
lines, which I had to edit; perhaps this was just a mailer glitch, or
is my patch program just missing a format?

I suggest that the name change be submitted as a separate patch,
thus making the substantive change clearer.

Paul Hilfinger