Re: glr.c cleanup

[Joel E. Denny]

On Wed, 7 Dec 2005, Paul Eggert wrote:

> Paul Hilfinger <address@hidden> writes:
>
> > the patch appeared to contain an extra space before context
> > lines, which I had to edit; perhaps this was just a mailer glitch, or
> > is my patch program just missing a format?
>
> I observed the same problem in another patch submitted by Joel.  I
> assume it's a mailer glitch, or perhaps something else in the
> procedure he's using to generate patches.  Joel, can you please check
> this?  It's making it harder to evaluate patches.

Sorry, when you mentioned this before, I assumed you were referring to my 
use of leading spaces vs. tabs.

I've been generating patches with cvs diff -p -u.  Am I missing a flag? 
Is this the wrong procedure?

> > I suggest that the name change be submitted as a separate patch,
> > thus making the substantive change clearer.
>
> Good idea.

Personally, I'm not concerned about the naming scheme.  I just need 
something consistent in order for the patch to work.

Let me know what the consensus is, and I'll post a single renaming patch. 
Once installed, I'll post the remaining cleanup as another patch... unless 
you'd like it broken up further.

Joel