Re: glr.c cleanup

[Joel E. Denny]

On Thu, 8 Dec 2005, Paul Hilfinger wrote:

> 
> > >>  (yyglrShift): Change parameter YYLTYPE* yylocp to YYLTYPE yyloc for
> > >>  consistency with parameter YYSTYPE yysval.
> > >
> > > I used yylocp here because the default location object is a multiword
> > > thing, and I wanted to avoid passing its value.
> > 
> > Minor issue, but what about YYSTYPE* yyvalp instead?  This would be fairly 
> > consistent with other functions.

To be clear, by `Minor issue', I wasn't belittling your efficiency 
concern.  I was belittling my consistency concern.

> You could do that if you wanted.  These are parameters that would be
> const Foo& in C++, to avoid gratuitous invocation of a copy
> constructor. 

Thanks.

Joel