bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] -D, --define.


From: Akim Demaille
Subject: Re: [PATCH] -D, --define.
Date: Mon, 10 Nov 2008 09:07:26 +0100


Le 7 nov. 08 à 23:06, Joel E. Denny a écrit :

On Tue, 29 Jul 2008, Akim Demaille wrote:

+static
+location
+command_line_location()
+{
+  location res;
+  /* "<command line>" is used in GCC's messages about -D. */
+ boundary_set (&res.start, uniqstr_new ("<command line>"), optind, -1);
+  res.end = res.start;
+  return res;
+}

In muscle_tab.c and bison.m4, `[Bison:muscle_percent_define_default]' and
`[Bison:b4_percent_define_default]' are some other pseudo file names.
Unlike `<command line>', these should only be printed by Bison when
there's a developer bug.  Nevertheless, we should be consistent about
whether we use square or angle brackets.  I don't care which.

You are right. I would then promote the <> notation, together with a human readable location. The examples you mention look way too much like a bug in Bison (this is was I was told by co-workers who happened to have seen these locations) because they look like something that was not expanded.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]