bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] -D, --define.


From: Joel E. Denny
Subject: Re: [PATCH] -D, --define.
Date: Mon, 10 Nov 2008 14:20:33 -0500 (EST)

On Mon, 10 Nov 2008, Joel E. Denny wrote:

> I remember you reported that.  [] does look like overquoted M4, so I agree 
> that <> is better.
> 
> Just to be clear, when these locations are printed, there is a bug in 
> Bison... or at least in a skeleton.  That is, I can't imagine that Bison 
> should have any reason to report the locations of internal defaults unless 
> there is something wrong with them.  Of course, if you'd like to propose 
> better messages here, I'm definitely fine with that.

On second thought, Bison may some day wish to report a conflict between 
the default value of one variable and a user-specified value of another 
variable.  In that case, Bison might report both locations.  I don't think 
that's possible now, but maybe it'll happen in the future.

In muscle_tab.c and bison.m4, maybe both of the pseudo file names 
`[Bison:muscle_percent_define_default]' and 
`[Bison:b4_percent_define_default]' should become just `<default>'.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]