Windows Build: Warning Levels 2 & 3

[Conrad T. Pino]

Hi Larry,

> From: Larry Jones [mailto:lawrence.jones@ugsplm.com]
> 
> > I don't know enough about CVS to have a meaningful opinion on where
> > the warning level should be for CVS.

The warning level default in new VC6 .dsp projects files is "/W3" which
may explain why *every* .dsp file on the feature branch is set the same.

> I don't know how Microsoft defines their warning levels, but in my
> opinion the current setting is too high.  If you run the compiler from
> the command line and don't specify a warning level, what do you get? 
> That's probably what we should be specifying.

I did two forced rebuilds at levels 2 and 3 and have attached as files.
The difference listing show the warnings added at level 3 are appending
in line to this message.

I would always regret losing:

        warning C4013: 'rpl_realloc' undefined; assuming extern returning int

If nothing else were pressing I would eventually fix:

        warning C4102: 'yyerrlab' : unreferenced label
        warning C4101: 'destination' : unreferenced local variable
        warning C4018: '<' : signed/unsigned mismatch

Oops, that means I'd keep the all but that's not a strong opinion.

I'm bowing out of this topic since IMO the active maintainers and
Windows builders should decide.  I'm maintaining a local version
to meet my needs.

The total level 3 warning count dropped after Derek imported a new
"lib/regex.*" set.  Not a suggestion but worthwhile considering.

> -Larry Jones

Conrad

> It works on the same principle as electroshock therapy. -- Calvin

Are you sure it won't hurt?
=============================
The difference listing between level 2 and 3 follows:

Files:  warning_level_2.txt  warning_level_3.txt
------------
------
>   13: getdate.c(1074) : warning C4013: 'rpl_realloc' undefined; assuming 
> extern returning int
>   14: getdate.c(1167) : warning C4102: 'yyerrlab' : unreferenced label
>   15: getdate.c(1162) : warning C4102: 'yynewerror' : unreferenced label
------------
------
>   24: h:\conrad\projects\ccvs 1.12\lib\regex.c(6819) : warning C4101: 
> 'destination' : unreferenced local variable
>   25: h:\conrad\projects\ccvs 1.12\lib\regex.c(6983) : warning C4101: 
> 'destination' : unreferenced local variable
>   26: h:\conrad\projects\ccvs 1.12\lib\regex.c(7040) : warning C4101: 
> 'destination' : unreferenced local variable
>   27: h:\conrad\projects\ccvs 1.12\lib\regex.c(7269) : warning C4101: 
> 'destination' : unreferenced local variable
>   28: h:\conrad\projects\ccvs 1.12\lib\regex.c(7282) : warning C4101: 
> 'destination' : unreferenced local variable
------------
------
>   34: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(430) : warning C4018: '<' : 
> signed/unsigned mismatch
>   35: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(432) : warning C4018: '<' : 
> signed/unsigned mismatch
>   36: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(469) : warning C4018: '>' : 
> signed/unsigned mismatch
>   37: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(497) : warning C4018: '<' : 
> signed/unsigned mismatch
>   38: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(506) : warning C4018: '>' : 
> signed/unsigned mismatch
>   39: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(517) : warning C4018: '>' : 
> signed/unsigned mismatch
>   40: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(537) : warning C4018: '<' : 
> signed/unsigned mismatch
>   41: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(550) : warning C4018: '<' : 
> signed/unsigned mismatch
>   42: H:\Conrad\Projects\ccvs 1.12\diff\analyze.c(568) : warning C4018: '<' : 
> signed/unsigned mismatch
------------
------
>   48: H:\Conrad\Projects\ccvs 1.12\diff\diff.c(603) : warning C4013: 'error' 
> undefined; assuming extern returning int
------------
------
>   51: H:\Conrad\Projects\ccvs 1.12\diff\dir.c(114) : warning C4018: '<' : 
> signed/unsigned mismatch
------------
------
>   60: H:\Conrad\Projects\ccvs 1.12\diff\io.c(143) : warning C4018: '<' : 
> signed/unsigned mismatch
>   61: H:\Conrad\Projects\ccvs 1.12\diff\io.c(149) : warning C4018: '<' : 
> signed/unsigned mismatch
------------
------
>  160: H:\Conrad\Projects\ccvs 1.12\src\import.c(1466) : warning C4018: '!=' : 
> signed/unsigned mismatch
------------
------
>  165: H:\Conrad\Projects\ccvs 1.12\src\login.c(534) : warning C4013: 
> 'getpass' undefined; assuming extern returning int
------------
------
>  175: H:\Conrad\Projects\ccvs 1.12\windows-NT\ndir.c(62) : warning C4013: 
> 'xmalloc' undefined; assuming extern returning int
------------
------
>  181: H:\Conrad\Projects\ccvs 1.12\windows-NT\pwd.c(186) : warning C4013: 
> 'xmalloc' undefined; assuming extern returning int
------------
------
>  185: H:\Conrad\Projects\ccvs 1.12\src\rcs.c(1522) : warning C4018: '>' : 
> signed/unsigned mismatch
------------
------
>  210: H:\Conrad\Projects\ccvs 1.12\lib\vasnprintf.c(811) : warning C4018: 
> '>=' : signed/unsigned mismatch
>  211: H:\Conrad\Projects\ccvs 1.12\lib\vasnprintf.c(818) : warning C4018: 
> '>=' : signed/unsigned mismatch
------------
<  197: cvs.exe - 0 error(s), 54 warning(s)
------
>  225: cvs.exe - 0 error(s), 82 warning(s)
------------

warning_level_2.txt
Description: Text document

warning_level_3.txt
Description: Text document